On Tue, Mar 12, 2019 at 09:11:43AM +0100, Gerd Hoffmann wrote: > HWADDR_PRIx can't be used in tracing, use PRIx64 instead. > > Signed-off-by: Gerd Hoffmann <[email protected]> > --- > hw/display/trace-events | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/display/trace-events b/hw/display/trace-events > index 80993cc4d913..c09854314b03 100644 > --- a/hw/display/trace-events > +++ b/hw/display/trace-events > @@ -140,5 +140,5 @@ sii9022_write_reg(uint8_t addr, uint8_t val) "addr > 0x%02x, val 0x%02x" > sii9022_switch_mode(const char *mode) "mode: %s" > > # hw/display/ati*.c > -ati_mm_read(unsigned int size, uint64_t addr, const char *name, uint64_t > val) "%u 0x%"HWADDR_PRIx " %s -> 0x%"PRIx64 > -ati_mm_write(unsigned int size, uint64_t addr, const char *name, uint64_t > val) "%u 0x%"HWADDR_PRIx " %s <- 0x%"PRIx64 > +ati_mm_read(unsigned int size, uint64_t addr, const char *name, uint64_t > val) "%u 0x%"PRIx64 " %s -> 0x%"PRIx64 > +ati_mm_write(unsigned int size, uint64_t addr, const char *name, uint64_t > val) "%u 0x%"PRIx64 " %s <- 0x%"PRIx64
FWIW, it would be valid to just make log_stap.py automatically convert HWADDR_PRIx into "%x", which will have the same functional effect and protect us against similar cases in the future. I don't mind which solution is used though so Reviewed-by: Daniel P. Berrangé <[email protected]> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
