On 3/5/19 12:51 AM, Thomas Huth wrote:
On 01/03/2019 19.59, Jason J. Herne wrote:
Add proper typedefs to all structs and modify all bit fields to use consistent
formatting.
Signed-off-by: Jason J. Herne <[email protected]>
Reviewed-by: Collin Walling <[email protected]>
Reviewed-by: Farhan Ali <[email protected]>
---
pc-bios/s390-ccw/cio.h | 152 ++++++++++++++++++++++----------------------
pc-bios/s390-ccw/s390-ccw.h | 8 ---
2 files changed, 76 insertions(+), 84 deletions(-)
diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h
index 1a0795f..2f58256 100644
--- a/pc-bios/s390-ccw/cio.h
+++ b/pc-bios/s390-ccw/cio.h
[...]
-struct subchannel_id {
- __u32 cssid : 8;
- __u32 : 4;
- __u32 m : 1;
- __u32 ssid : 2;
- __u32 one : 1;
- __u32 sch_no : 16;
-} __attribute__ ((packed, aligned(4)));
+} __attribute__ ((packed, aligned(4))) Schib;
+
+typedef struct subchannel_id {
+ __u32 cssid:8;
+ __u32:4;
__u32:4 looks a little bit funny. Not sure, but maybe this should be
given a name like "reserved" or so?
Perhaps, but this is not my code. I was just cleaning up the style. If you feel strongly
that this patch is the place to give this a name, I can do that.
--
-- Jason J. Herne ([email protected])
