On 01/03/2019 19.59, Jason J. Herne wrote:
> Introduce inline functions to convert between pointers and unsigned 32-bit
> ints. These are used to hide the ugliness required to avoid compiler
> warnings.
>
> Signed-off-by: Jason J. Herne <[email protected]>
> Acked-by: Cornelia Huck <[email protected]>
> ---
> pc-bios/s390-ccw/helper.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 pc-bios/s390-ccw/helper.h
>
> diff --git a/pc-bios/s390-ccw/helper.h b/pc-bios/s390-ccw/helper.h
> new file mode 100644
> index 0000000..b8bc61b
> --- /dev/null
> +++ b/pc-bios/s390-ccw/helper.h
> @@ -0,0 +1,16 @@
> +#ifndef S390_CCW_HELPER_H
> +#define S390_CCW_HELPER_H
> +
> +/* Avoids compiler warnings when casting a pointer to a u32 */
> +static inline uint32_t ptr2u32(void *ptr)
> +{
Would it make sense to add an IPL_assert(ptr <= 0xffffffff) here?
> + return (uint32_t)(uint64_t)ptr;
> +}
> +
> +/* Avoids compiler warnings when casting a u32 to a pointer */
> +static inline void *u32toptr(uint32_t n)
> +{
> + return (void *)(uint64_t)n;
> +}
> +
> +#endif
Reviewed-by: Thomas Huth <[email protected]>
