From: Paul Durrant <[email protected]> The assignment to 'p' is unnecessary as the code will either goto 'invalid' or p will get overwritten.
Spotted by Coverity: CID 1398638 Reported-by: Peter Maydell <[email protected]> Signed-off-by: Paul Durrant <[email protected]> Acked-by: Anthony PERARD <[email protected]> Message-Id: <[email protected]> Signed-off-by: Anthony PERARD <[email protected]> --- hw/block/xen-block.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 5012af9cb6..29afe2703a 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -413,8 +413,7 @@ static void xen_block_set_vdev(Object *obj, Visitor *v, const char *name, } if (*end == 'p') { - p = (char *) ++end; - if (*end == '\0') { + if (*(++end) == '\0') { goto invalid; } } -- Anthony PERARD
