On Mon, 25 Feb 2019 09:25:30 +0800 Wei Yang <richardw.y...@linux.intel.com> wrote:
> All the example code are indented with four spaces except this one. > > Fix this by adding four spaces here. > > Signed-off-by: Wei Yang <richardw.y...@linux.intel.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Reviewed-by: Igor Mammedov <imamm...@redhat.com> > --- > CODING_STYLE | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index 1bccf4f865..e6d21dcd67 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -137,10 +137,10 @@ block to a separate function altogether. > When comparing a variable for (in)equality with a constant, list the > constant on the right, as in: > > -if (a == 1) { > - /* Reads like: "If a equals 1" */ > - do_something(); > -} > + if (a == 1) { > + /* Reads like: "If a equals 1" */ > + do_something(); > + } > > Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. > Besides, good compilers already warn users when '==' is mis-typed as '=',