Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: [email protected] Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' b743b2708d target/riscv: Remaining rvc insn reuse 32 bit translators 97151915f5 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 64110323f1 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 27afdd0f91 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 7a460bcb99 target/riscv: Convert @cs_2 insns to share translation functions 2be9091aba target/riscv: Remove decode_RV32_64G() 2725a49a4b target/riscv: Remove gen_system() ddbd02c7b3 target/riscv: Rename trans_arith to gen_arith 1694fea27d target/riscv: Remove manual decoding of RV32/64M insn c863548047 target/riscv: Remove shift and slt insn manual decoding a210ebe4d2 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 3bdee97f0b target/riscv: Move gen_arith_imm() decoding into trans_* functions b543464822 target/riscv: Remove manual decoding from gen_store() 9ff5a67fcc target/riscv: Remove manual decoding from gen_load() 2d1c64f887 target/riscv: Remove manual decoding from gen_branch() bdaf5ddf31 target/riscv: Remove gen_jalr() 78a6813f86 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 2b5d0b8dca target/riscv: Convert quadrant 1 of RVXC insns to decodetree cf530fdd73 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 2b10a8540e target/riscv: Convert RV priv insns to decodetree 0257600022 target/riscv: Convert RV64D insns to decodetree 1ece744398 target/riscv: Convert RV32D insns to decodetree 399b83982f target/riscv: Convert RV64F insns to decodetree 9a7dfa767f target/riscv: Convert RV32F insns to decodetree 7d41f5f383 target/riscv: Convert RV64A insns to decodetree 4622cedb38 target/riscv: Convert RV32A insns to decodetree a7d64cae55 target/riscv: Convert RVXM insns to decodetree a6218396a7 target/riscv: Convert RVXI csr insns to decodetree 22bd7ea86a target/riscv: Convert RVXI fence insns to decodetree 7a82ec67ed target/riscv: Convert RVXI arithmetic insns to decodetree 857a130e0d target/riscv: Convert RV64I load/store insns to decodetree cc3e90fc2c target/riscv: Convert RV32I load/store insns to decodetree e5c2ac77b0 target/riscv: Convert RVXI branch insns to decodetree 2d7a3e4329 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 2d7a3e4329be (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit e5c2ac77b074 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit cc3e90fc2cc0 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 857a130e0d4d (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 7a82ec67edab (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 22bd7ea86ae4 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit a6218396a705 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit a7d64cae556e (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 4622cedb385c (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 7d41f5f383b4 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 9a7dfa767f2d (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 399b83982f45 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 1ece7443984a (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 025760002299 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 2b10a8540e59 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit cf530fdd733f (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 2b5d0b8dca51 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 78a6813f8648 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit bdaf5ddf312d (target/riscv: Remove gen_jalr()) 20/34 Checking commit 2d1c64f88730 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 9ff5a67fcc8b (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit b543464822b5 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 3bdee97f0b9e (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit a210ebe4d2d5 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit c86354804726 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 1694fea27daa (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit ddbd02c7b30e (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 2725a49a4bab (target/riscv: Remove gen_system()) 29/34 Checking commit 2be9091abae5 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 7a460bcb995e (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit 27afdd0f91c9 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 64110323f178 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 97151915f5d9 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit b743b2708d74 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
