Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: [email protected] Subject: [Qemu-devel] [PATCH v3 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 1d4a9cbd21 target/arm: Rely on hflags correct in cpu_get_tb_cpu_state c6ed04439c target/arm: Rebuild hflags at el changes and MSR writes 37d8117eac target/arm: Split out recompute_hflags et al === OUTPUT BEGIN === 1/3 Checking commit 37d8117eacef (target/arm: Split out recompute_hflags et al) WARNING: Block comments use a leading /* on a separate line #125: FILE: target/arm/helper.c:12860: + /* v8M always applies stack limit checks unless CCR.STKOFHFNMIGN is WARNING: Block comments use a leading /* on a separate line #170: FILE: target/arm/helper.c:12905: + /* If SVE is disabled, but FP is enabled, total: 0 errors, 2 warnings, 368 lines checked Patch 1/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/3 Checking commit c6ed04439c57 (target/arm: Rebuild hflags at el changes and MSR writes) 3/3 Checking commit 1d4a9cbd219d (target/arm: Rely on hflags correct in cpu_get_tb_cpu_state) ERROR: Use g_assert or g_assert_not_reached #75: FILE: target/arm/helper.c:12982: + g_assert_cmphex(flags, ==, check_flags); total: 1 errors, 0 warnings, 34 lines checked Patch 3/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
