Patchew URL: https://patchew.org/QEMU/20190219233421.388-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190219233421.388-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v2 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' f6e7ff3298 target/arm: Rely on hflags correct in cpu_get_tb_cpu_state 2ccfa3184b target/arm: Rebuild hflags at el changes and MSR writes eed68828e4 target/arm: Split out recompute_hflags et al === OUTPUT BEGIN === 1/3 Checking commit eed68828e48e (target/arm: Split out recompute_hflags et al) WARNING: Block comments use a leading /* on a separate line #277: FILE: target/arm/helper.c:12912: + /* If SVE is disabled, but FP is enabled, WARNING: Block comments use a leading /* on a separate line #358: FILE: target/arm/helper.c:12993: + /* The SS_ACTIVE and PSTATE_SS bits correspond to the state machine total: 0 errors, 2 warnings, 363 lines checked Patch 1/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/3 Checking commit 2ccfa3184bd5 (target/arm: Rebuild hflags at el changes and MSR writes) 3/3 Checking commit f6e7ff32983e (target/arm: Rely on hflags correct in cpu_get_tb_cpu_state) ERROR: Use g_assert or g_assert_not_reached #75: FILE: target/arm/helper.c:12989: + g_assert_cmphex(flags, ==, check_flags); total: 1 errors, 0 warnings, 34 lines checked Patch 3/3 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190219233421.388-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com