Jan Kiszka <[email protected]> writes:
> On 21.02.19 17:05, Eric Blake wrote:
>> On 2/21/19 9:53 AM, David Kiarie wrote:
>>> the occurrence of my name and email on the files below may have led to
>>> some confusion in the reporting of a few recent bugs.
>>>
>>> i have therefore choosen to snip it.
>>
>> Dropping an email from the copyright line makes sense; dropping the
>> Copyright declaration altogether is a bit odd (the GPL works only in
>> tandem with a copyright assertion) - but as you are the author of the
>> line and copyright holder of your contributions, I am not in a position
>> to say you are wrong in removing it, only that it looks odd.
>>
>
> Yeah, indeed.
>
> David, also note that you probably have been addressed because
> scripts/get_maintainer.pl will look into the git history of files that
> some patch addresses and pick up significant and/or recent
> contributors from there.
MAINTAINERS covers these files, so the most common use of
get_maintainer.pl won't list anyone not listed there:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch]
Paolo Bonzini <[email protected]> (maintainer:X86)
Richard Henderson <[email protected]> (maintainer:X86)
Eduardo Habkost <[email protected]> (maintainer:X86)
"Michael S. Tsirkin" <[email protected]> (supporter:PC)
Marcel Apfelbaum <[email protected]> (supporter:PC)
[email protected] (open list:All patches CC here)
David's contributions have aged out of --git:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git
"Michael S. Tsirkin" <[email protected]>
(supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%)
Marcel Apfelbaum <[email protected]> (supporter:PC)
Paolo Bonzini <[email protected]> (maintainer:X86)
Richard Henderson <[email protected]> (maintainer:X86,commit_signer:1/7=14%)
Eduardo Habkost <[email protected]> (maintainer:X86)
Peter Xu <[email protected]> (commit_signer:6/7=86%,commit_signer:4/5=80%)
Brijesh Singh <[email protected]>
(commit_signer:5/7=71%,commit_signer:4/5=80%)
"Alex Bennée" <[email protected]> (commit_signer:1/7=14%)
Jan Kiszka <[email protected]> (commit_signer:1/5=20%)
[email protected] (open list:All patches CC here)
However, --git-blame still lists him:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame
Paolo Bonzini <[email protected]> (maintainer:X86,commits:7/24=29%)
Richard Henderson <[email protected]> (maintainer:X86)
Eduardo Habkost <[email protected]> (maintainer:X86,commits:7/24=29%)
"Michael S. Tsirkin" <[email protected]>
(supporter:PC,commits:26/24=100%,commits:14/8=100%)
Marcel Apfelbaum <[email protected]> (supporter:PC)
David Kiarie <[email protected]> (authored
lines:1176/1645=71%,authored lines:274/373=73%)
Brijesh Singh <[email protected]> (authored lines:403/1645=24%,authored
lines:93/373=25%,commits:4/8=50%)
Peter Xu <[email protected]> (commits:10/24=42%,commits:4/8=50%)
David Gibson <[email protected]> (commits:7/24=29%)
Jan Kiszka <[email protected]> (commits:1/8=12%)
Prasad J Pandit <[email protected]> (commits:1/8=12%)
[email protected] (open list:All patches CC here)
--help admonishes:
Using "--git-blame" is slow and may add old committers and authors
that are no longer active maintainers to the output.
> There should be some opt-out statement from
> that, but I don't recall how.
I don't think get_maintainer.pl supports a blacklist of people who don't
want to be pestered anymore.
