On 2/19/19 4:58 AM, Peter Maydell wrote: > Create and connect the MHUs in the SSE-200. > > Signed-off-by: Peter Maydell <[email protected]> > --- > include/hw/arm/armsse.h | 3 ++- > hw/arm/armsse.c | 40 ++++++++++++++++++++++++++++++---------- > 2 files changed, 32 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson <[email protected]> > + /* > + * An SSE-200 with only one CPU should have only one MHU created, > + * with the region where the second MHU usually is being RAZ/WI. > + * We don't implement that SSE-200 config; if we want to support > + * it then this code needs to be enhanced to handle creating the > + * RAZ/WI region instead of the second MHU. > + */ > + assert(info->num_cpus > 1); > + > + for (i = 0; i < ARRAY_SIZE(s->mhu); i++) { Nit: x > 1 is probably better as x == ARRAY_SIZE(s->mhu). r~
