On 2/20/19 9:42 AM, Marc-André Lureau wrote: > Simplify the code around qmp_dispatch(): > - rely on qmp_dispatch/check_obj() for message checking > - have a single send_response() point > - constify send_response() argument > > It changes a couple of error messages: > > * When @req isn't a dictionary, from > Invalid JSON syntax > to > QMP input must be a JSON object > > * When @req lacks member "execute", from > this feature or command is not currently supported > to > QMP input lacks member 'execute' > > CC: Michael Roth <[email protected]> > Signed-off-by: Marc-André Lureau <[email protected]> > --- > qga/main.c | 47 +++++++++-------------------------------------- > 1 file changed, 9 insertions(+), 38 deletions(-)
Nice simplification. Reviewed-by: Eric Blake <[email protected]> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
