Hi,
On 2/19/19 2:31 AM, Wei Yang wrote:
> We didn't specify the indent rule for multiline code here, which may
> misleading users. And in current code, the code use different rules.
>
> Add this rule in CODING_STYLE to make sure this is clear to every one.
>
> Signed-off-by: Wei Yang <[email protected]>
> Suggested-by: Igor Mammedov <[email protected]>
> ---
> CODING_STYLE | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> index ec075dedc4..73f66ca185 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -29,6 +29,32 @@ Spaces of course are superior to tabs because:
>
> Do not leave whitespace dangling off the ends of lines.
>
> +1.1 Multiline Indent
> +
> +There are several places where indent is necessary:
> +
> + - struct definition
> + - if/else
> + - while/for
> + - function definition & call
> +
> +All the above cases apply the same rule: indent with four spaces.
> +
> +While the last three case may face another situation: code should spread into
> +several lines. In this case the rule is align the new line with first
> +parentheses.
> +
> +For example:
> +
> + if (a == 1 &&
> + b == 2)
> +
> + while (a == 1 &&
> + b == 2)
> +
> + do_something(arg1, arg2
> + arg3)
Thanks for clearing this.
What is still unclear is what to do when a function name is over 60
characters (you follow a library/API and can not shorten it), for example:
static void ccid_card_vscard_handle_message(PassthruState *card,
const VSCMsgHeader *scr_msg_header);
What is the project guideline in this case?
(Cc'ed Peter).
> +
> 2. Line width
>
> Lines should be 80 characters; try not to make them longer.
>
