Hi Peter, On 2/14/19 6:35 PM, Peter Maydell wrote: > On Tue, 5 Feb 2019 at 17:33, Eric Auger <[email protected]> wrote: >> This series aims to bump the 255GB RAM limit in machvirt and to >> support device memory in general, and especially PCDIMM/NVDIMM. > >> Functionally, the series is split into 3 parts: >> 1) bump of the initial RAM limit [1 - 10] and change in >> the memory map >> 2) Support of PC-DIMM [11 - 14] >> 3) Support of NV-DIMM [15 - 18] >> >> 1) can be upstreamed before 2 and 2 can be upstreamed before 3. > > Hi Eric; sorry I haven't reviewed this series earlier. I think > that 1-10 are pretty near to ready to go in; maybe the easiest > path is to do a respin of just those with the review issues fixed?
No problem. Thank you for the review. Yes I will quickly respin the patches you reviewed. > > I'm a long way from being expert in the PC-DIMM/NV-DIMM stuff, so > I'm going to be reliant on other people to review those parts. > > I don't know if your series needs anything from linux-headers > which isn't already in QEMU master after the update to match > 5.0rc1 -- if not you could drop the header-sync patch. 5.0-rc1 should be OK so I think I can drop the header sync. Thanks Eric > > thanks > -- PMM >
