Paolo Bonzini <[email protected]> writes:

> On 13/02/19 10:49, Markus Armbruster wrote:
>> * Define QAPI_COMMON_MODULES, QAPI_TARGET_MODULES and QAPI_MODULES in
>>   Makefile.obj
>> 
>> * Add to util-obj-y in Makefile.obj
>> 
>> * Add to obj-y in Makefile.target
>
> Why can't both be in Makefile.objs, or in qapi/Makefile.objs?

When I try either place, I get

      LINK    x86_64-softmmu/qemu-system-x86_64
    monitor.o: In function `qmp_query_qmp_schema':
    /work/armbru/qemu/monitor.c:1136: undefined reference to `qmp_schema_qlit'
    [more errors...]

Compiling with V=1 confirms qapi-introspect.o isn't in $(all-obj-y).

I think this is the case because Makefile.target has

    all-obj-y := $(obj-y)

before

    include $(SRC_PATH)/Makefile.objs

If I move the former below the latter (without really understanding the
consequences), I get

    make[1]: *** No rule to make target '9pfs/', needed by 'qemu-system-x86_64'.
    make[1]: *** No rule to make target 'acpi/', needed by 'qemu-system-x86_64'.
    make[1]: *** No rule to make target 'adc/', needed by 'qemu-system-x86_64'.
    [many, many more...]

What now?

Reply via email to