On 2019-02-04 11:48, Cornelia Huck wrote:
> On Tue, 29 Jan 2019 08:29:13 -0500
> "Jason J. Herne" <[email protected]> wrote:
>
>> Add proper typedefs to all structs and modify all bit fields to use
>> consistent
>> formatting.
>>
>> Signed-off-by: Jason J. Herne <[email protected]>
>> Reviewed-by: Collin Walling <[email protected]>
>> ---
>> pc-bios/s390-ccw/cio.h | 86
>> ++++++++++++++++++++++-----------------------
>> pc-bios/s390-ccw/s390-ccw.h | 8 -----
>> 2 files changed, 43 insertions(+), 51 deletions(-)
>>
>> diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h
>> index 1a0795f..a48eee5 100644
>> --- a/pc-bios/s390-ccw/cio.h
>> +++ b/pc-bios/s390-ccw/cio.h
>> @@ -53,12 +53,12 @@ struct schib_config {
>> __u64 mba;
>> __u32 intparm;
>> __u16 mbi;
>> - __u32 isc:3;
>> - __u32 ena:1;
>> - __u32 mme:2;
>> - __u32 mp:1;
>> - __u32 csense:1;
>> - __u32 mbfc:1;
>> + __u32 isc : 3;
>> + __u32 ena : 1;
>> + __u32 mme : 2;
>> + __u32 mp : 1;
>> + __u32 csense : 1;
>> + __u32 mbfc : 1;
>> } __attribute__ ((packed));
>
> This seems to make checkpatch unhappy... maybe consolidate to the other
> formatting instead?
Yeah, you get lots of these errors this way:
ERROR: spaces prohibited around that ':' (ctx:WxW)
#141: FILE: pc-bios/s390-ccw/cio.h:56:
+ __u32 isc : 3;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#142: FILE: pc-bios/s390-ccw/cio.h:57:
+ __u32 ena : 1;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#143: FILE: pc-bios/s390-ccw/cio.h:58:
+ __u32 mme : 2;
^
...
Not sure whether it's a checkpatch warning or really our official coding
style, but anyway, I'd rather prefer to keep checkpatch calm here and
thus no spaces around the ':' please.
Thomas
