Hi On Mon, Feb 11, 2019 at 10:52 AM Peter Maydell <[email protected]> wrote: > > On Mon, 11 Feb 2019 at 07:57, Thomas Huth <[email protected]> wrote: > > > > On 2019-02-10 23:12, Howard Spoelstra wrote: > > > Hi, > > > > > > I just cross compiled Qemu-system-ppc for Windows on Fedora 29 and > > > discovered slirp does not work anymore. Tap networking works fine. > > > Bisecting got me here: > > > > > > a9d8b3ec4385793815d7121785730422fa3dfb68 is the first bad commit > > > commit a9d8b3ec4385793815d7121785730422fa3dfb68 > > > Author: Marc-André Lureau <[email protected]> > > > Date: Thu Jan 17 15:43:52 2019 +0400 > > > > > > slirp: replace remaining qemu headers dependency > > > > > > Except for the migration code which is gated by WITH_QEMU, only > > > include our own headers, so libslirp can be built standalone. > > > > > > Signed-off-by: Marc-André Lureau <[email protected]> > > > Signed-off-by: Samuel Thibault <[email protected]> > > > > > > :040000 040000 cd06df21ed96497cd12f2a20adb3d66cb0da8010 > > > ab5afd3f50910e39b2b700722cd47de8f0cf9e2c M slirp > > > > Thanks for bisecting the issue already! ... adding Marc-André and Samuel > > to the thread, maybe they have a clue what might be wrong here... > > Probably you've missed something in copying the "work around > weird Windows host stuff" bits from osdep.h and sysemu/os-win32.h. > For instance you don't seem to have an equivalent of most of the > wrapped functions that set errno -- eg os-win32.h defines recv > to be qemu_recv_wrap, which is a function in util/oslib-win32.c.
It looks like you are right. I am working on a patch set to fix it asap. thanks -- Marc-André Lureau
