On 30/01/19 12:02, Thomas Huth wrote: > On 2019-01-30 11:25, Thomas Huth wrote: >> On 2019-01-30 11:17, Paolo Bonzini wrote: >>> On 30/01/19 10:43, Thomas Huth wrote: >>>> + select LSI_SCSI_PCI >>> >>> Should NE2000_ISA and LSI_SCSI_PCI be handled the same? Either rely on >>> "default y" for both, or select both (I think I prefer the former). >> >> Yes. IMHO we should use "select XXX" if the machine has a hard >> requirement for a device, and "default y" if it can also somehow work >> without the device. In this case, I did not look carefully enough, since >> it is apparently possible to use the 40p machine also without the LSI >> controller when you specify "-nodefaults". So I'll remove this in v2 and >> rely on the "default y" instead. > > Scratch that. The "select LSI_SCSI_PCI" is currently a hard requirement > here, otherwise I get a linker error like this: > > hw/ppc/prep.c:705: undefined reference to `lsi53c8xx_handle_legacy_cmdline' > > So I think we should keep this patch in its current shape. Of course > we still can clean that up later, but this should not be part of the > initial Kconfig patch series (which is already big enough).
Sounds good! Paolo
