Samuel Thibault <samuel.thiba...@gnu.org> writes:
> Alex Bennée, le lun. 28 janv. 2019 10:35:37 +0000, a ecrit: >> Samuel Thibault <samuel.thiba...@ens-lyon.org> writes: >> >> > Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> >> >> Is there a rationale as to why we should replace QEMU_BUILD_BUG_ON with >> G_STATIC_ASSERT or is it particular to these QEMU_BUILD_BUG_ON >> instances? It would be nice to have a little more context in the commit >> message. > > It is yet more work towards moving slirp/ to a separately-maintained > libslirp. thanks, that makes more sense. If you could just mention that in the commit it would save confusion about QEMU_BUILD_BUG_ON being deprecated ;-) With that: Reviewed-by: Alex Bennée <alex.ben...@linaro.org> -- Alex Bennée