Markus Armbruster <[email protected]> writes: > Marc-André posted v1 that relies on a QAPI schema language extension > 'top-unit' to permit splitting the generated code. Here is his cover > letter: > > The thrid and last part (of "[PATCH v2 00/54] qapi: add #if > pre-processor conditions to generated code") is about adding schema > conditions based on the target. > > For now, the qapi code is compiled in common objects (common to all > targets). This makes it impossible to add #if TARGET_ARM for example. > > The patch "RFC: qapi: learn to split the schema by 'top-unit'" > proposes to split the schema by "top-unit", so that generated code can > be built either in common objects or per-target. That patch is a bit > rough, I would like to get some feedback about the approach before > trying to improve it. The following patches demonstrate usage of > target-based #if conditions, and getting rid of the > qmp_unregister_command() hack. > > We already have a way to split generated code: QAPI modules. I took > the liberty to rework Marc-André's series to use a target module > instead. Less code, no change to the QAPI language. > > One of the patches (marked WIP) is a total hack. Fixable, but I want > to get this out for discussion first.
PATCH 01-02 make sense on their own; queued.
