On 1/22/19 1:28 AM, Bastian Koppelmann wrote: > gen_arith_imm() does a lot of decoding manually, which was hard to read > in case of the shift instructions and is not necessary anymore with > decodetree. > > Signed-off-by: Bastian Koppelmann <[email protected]> > Signed-off-by: Peer Adelt <[email protected]>
Reviewed-by: Richard Henderson <[email protected]> > + if (a->shamt >= TARGET_LONG_BITS) { > + return false; > + } Watch the funky indentation. > + if (a->rd != 0) { > + TCGv t = tcg_temp_new(); > + gen_get_gpr(t, a->rs1); > + > + tcg_gen_sari_tl(t, t, a->shamt); > + gen_set_gpr(a->rd, t); Likewise. r~
