On Mon, Jan 21, 2019 at 10:53:14AM +0000, Stefan Hajnoczi wrote:
> On Fri, Jan 18, 2019 at 12:14:14PM -0600, Eric Blake wrote:
> > On 1/18/19 11:31 AM, Daniel P. Berrangé wrote:
> > > +def c_macro_to_format(macro):
> > > + if macro.startswith("PRI"):
> > > + return macro[3]
> > > +
> > > + if macro == "TARGET_FMT_plx":
> > > + return "%016x"
> >
> > Do we really want to permit TARGET_FMT in our trace-events files, or
> > should that be fixed in hw/tpm/trace-events? See commit 73ff0610.
>
> TARGET_FMT_plx is constant across all QEMU targets. I think supporting
> it is nice since it makes writing trace events more natural/convenient.
Yep, I'm fine with supporting custom macros beyond PRI* in trace-events,
provided that they can be subsituted out with a simple formats code for
stap.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
