On 16.01.19 15:46, Eric Blake wrote:
> On 1/16/19 5:35 AM, David Hildenbrand wrote:
>> From: Pankaj Gupta <[email protected]>
>>
>> This is the current protoype of virtio-pmem. Support will require
>> machine changes for the architectures that will support it, so it will
>> not yet be compiled.
>>
>> TODO:
>> - Use separate struct for tracking requests internally
>> - Move request/response structs to linux headers
>> - Factor out linux header sync
>> - Drop debug printfs
>>
>> Signed-off-by: Pankaj Gupta <[email protected]>
>> [ MemoryDevice/MemoryRegion changes, cleanups, addr property "memaddr",
>> split up patches, unplug handler ]
>> Signed-off-by: David Hildenbrand <[email protected]>
>> ---
>
>> +++ b/qapi/misc.json
>> @@ -2949,6 +2949,29 @@
>> }
>> }
>>
>> +##
>> +# @VirtioPMEMDeviceInfo:
>> +#
>> +# VirtioPMEM state information
>> +#
>> +# @id: device's ID
>> +#
>> +# @memaddr: physical address in memory, where device is mapped
>> +#
>> +# @size: size of memory that the device provides
>> +#
>> +# @memdev: memory backend linked with device
>> +#
>> +# Since: 3.1
>
> Now 4.0
Indeed. (if we'll get it into 4.0 of course ;) )
>
>> +##
>> +{ 'struct': 'VirtioPMEMDeviceInfo',
>> + 'data': { '*id': 'str',
>> + 'memaddr': 'size',
>> + 'size': 'size',
>> + 'memdev': 'str'
>> + }
>> +}
>> +
>> ##
>> # @MemoryDeviceInfo:
>> #
>> @@ -2958,7 +2981,8 @@
>> ##
>> { 'union': 'MemoryDeviceInfo',
>
> Does this union need a documentation update that virtio-pmem was added
> in 4.0?
We can add that, makes sense!
Thanks!
>
>> 'data': { 'dimm': 'PCDIMMDeviceInfo',
>> - 'nvdimm': 'PCDIMMDeviceInfo'
>> + 'nvdimm': 'PCDIMMDeviceInfo',
>> + 'virtio-pmem': 'VirtioPMEMDeviceInfo'
>> }
>> }
>>
>>
>
--
Thanks,
David / dhildenb
