On Mon, 14 Jan 2019 at 01:08, Aleksandar Markovic <[email protected]> wrote: > I do understand the definition of cluster_index in the sense > of this series. However, it looks to me that the term > "cluster" is generally overused in areas where we work. > This may lead to some confusion for future developers, and > let me suggest some other name, like "tcg_cluster_index" or > "tcg_group_id", or "translation_group_id".
Note also that the cluster index is not purely a TCG concept -- it also (in master at the moment) affects the gdbstub interface. Different clusters appear as separate processes in gdb, whereas different CPUs in the same cluster are different threads in the same CPU. (And by default only the first cluster's CPUs will appear, unless you explicitly attach to the second cluster: this is a limitation of how gdb's UI handles multiple processes.) thanks -- PMM
