On 1/3/19 2:31 PM, Li Qiang wrote: > Spotted by Coverity: CID 1397070 Closing a CVE to open a CID :)
Fixes: bab9df35ce > > Signed-off-by: Li Qiang <[email protected]> > --- > hw/usb/dev-mtp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > index b19b576278..666bafd9e8 100644 > --- a/hw/usb/dev-mtp.c > +++ b/hw/usb/dev-mtp.c > @@ -666,6 +666,7 @@ static void usb_mtp_object_readdir(MTPState *s, MTPObject > *o) > } > dir = fdopendir(fd); > if (!dir) { > + close(fd); > return; This or: goto cleanup_fd; > } > #ifdef CONFIG_INOTIFY1 > @@ -682,6 +683,7 @@ static void usb_mtp_object_readdir(MTPState *s, MTPObject > *o) > usb_mtp_add_child(s, o, entry->d_name); > } > closedir(dir); And: cleanup_fd: > + close(fd); > } > > /* ----------------------------------------------------------------------- */ > Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
