On 12/18/18 3:14 PM, Stefan Hajnoczi wrote:

Please include a changelog in future patches.  For example:

v3:
  * Don't drop revents when a handler is modified [Stefan]

That way reviewers know what to look for and which issues you have
addressed.
Sorry, wasn't sure i had to do this in single commit patches without cover letter.
Thanks!  The worst case I can now imagine is if an fd is handled twice
due to a concurrent aio_set_fd_handler() call, but spurious
->io_read()/->io_write() should not cause problems.

Concurrent aio_set_fd_handlers should not be possible (not on the same AioContext at least) since we lock ctx->list_lock.

Remy


Reply via email to