On Mon, Dec 03, 2018 at 09:28:36AM -0700, Alex Williamson wrote: > Including all machine types that might have a pcie-root-port. > > Cc: Peter Maydell <[email protected]> > Cc: Michael S. Tsirkin <[email protected]> > Cc: Marcel Apfelbaum <[email protected]> > Cc: Paolo Bonzini <[email protected]> > Cc: Richard Henderson <[email protected]> > Cc: Eduardo Habkost <[email protected]> > Cc: David Gibson <[email protected]> > Signed-off-by: Alex Williamson <[email protected]> > --- [...] > +static void virt_3_1_instance_init(Object *obj) > +{ > + virt_4_0_instance_init(obj); > +} [...] > +/* > + * pseries-4.0 > + */ > +static void spapr_machine_4_0_instance_options(MachineState *machine) > +{ > +}
Not something specific about patch, but: Why exactly virt and pseries machines need separate instance initialization functions? I'd like to eventually make all machine-type-version-specific behavior instrospectable, so it needs to be available at class_init time. -- Eduardo
