On 11/29/18 6:08 PM, Paolo Bonzini wrote:
On 29/11/18 19:00, Paolo Bonzini wrote:
Subprocesses are created by glib without leaving the file descriptors
open. Therefore, g_test_message (and assertion failures, but those
trigger when things are going bad anyway) will think that it is writing
to the log file descriptor, but while actually stomping on the QMP
file descriptor or similar. This causes spurious failures, which are
as nice to debug as the reader can imagine. While I have opened a
pull request on GLib, this will probably take a while to propagate
to distros.
I found this while working on qgraph, but the fix is generic.
This is not a problem anymore if we switch from gtester to tap. Do we
want it fixed anyway or not?
If there is no -rc4, I'm fine if we drop this patch in favor of your
other patches for TAP. But if we have -rc4, this may still be useful for
inclusion in 3.1 for testsuite robustness.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
