On Wed, Nov 21, 2018 at 11:30:41AM -0600, Eric Blake wrote: > On 11/21/18 6:23 AM, Michael S. Tsirkin wrote: > > > > > > > I agree it is good to preserve fcntl flags though, so this patch > > > looks desirable. > > > > > > Reviewed-by: Daniel P. Berrangé <[email protected]> > > > > Sure > > > > Acked-by: Michael S. Tsirkin <[email protected]> > > > > but really not for this release I guess as we are in freeze. > > We're in freeze, so the criteria is: Does this fix a bug that we would > otherwise not want in 3.1. If the code is pre-existing (that is, if 3.0 was > released with the same problem), or then delaying the patch to 4.0 is an > easier call to make. If the problem is new to 3.1, then fixing it for -rc3 > is still reasonable with maintainer discretion (although once -rc3 lands, we > want as little as possible to go into -rc4, even if our track record says we > will be unable to avoid -rc4 altogether). > > I think that losing flags is likely enough to be a noticeable bug worth > fixing for 3.1, but I did not research when the problem was introduced, so I > don't have a strong preference for 3.1 vs. 4.0.
Maintainer in this case is Jason, so it's up to him. > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org
