David Hildenbrand <[email protected]> writes:
> Let's use the new function. "NaN" and "inf" are now properly rejected.
>
> Signed-off-by: David Hildenbrand <[email protected]>
Whether this is a bug fix or just a change is debatable. But the commit
message's title should highlight the change. Perhaps you want to steal
from the one I suggested for the previous patch.
We need to assess backward compatibility impact. I can do that.
> ---
> qapi/string-input-visitor.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
> index b3fdd0827d..b89c6c4e06 100644
> --- a/qapi/string-input-visitor.c
> +++ b/qapi/string-input-visitor.c
> @@ -20,6 +20,7 @@
> #include "qemu/option.h"
> #include "qemu/queue.h"
> #include "qemu/range.h"
> +#include "qemu/cutils.h"
>
>
> struct StringInputVisitor
> @@ -313,12 +314,9 @@ static void parse_type_number(Visitor *v, const char
> *name, double *obj,
> Error **errp)
> {
> StringInputVisitor *siv = to_siv(v);
> - char *endp = (char *) siv->string;
> double val;
>
> - errno = 0;
> - val = strtod(siv->string, &endp);
> - if (errno || endp == siv->string || *endp) {
> + if (qemu_strtod_finite(siv->string, NULL, &val)) {
> error_setg(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : "null",
> "number");
> return;
