[Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers

[Paolo Bonzini]

On 03/05/2011 01:34 PM, Peter Maydell wrote:
>>  +        VMSTATE_UINT32(sys_cfgdata, arm_sysctl_state),
>>  +        VMSTATE_UINT32(sys_cfgctrl, arm_sysctl_state),
>>  +        VMSTATE_UINT32(sys_cfgstat, arm_sysctl_state),
>>            VMSTATE_END_OF_LIST()
>>        }
>
>  You need to present the fields as version 2-only.
Can you give an example/explanation? docs/migration.txt doesn't
seem to cover this...

Sure, sorry for being terse. It simply needs to be:

        VMSTATE_UINT32_V(sys_cfgdata, arm_sysctl_state, 2),
        VMSTATE_UINT32_V(sys_cfgctrl, arm_sysctl_state, 2),
        VMSTATE_UINT32_V(sys_cfgstat, arm_sysctl_state, 2),

Also, minimum_version_id needs to remain 1 since you do support loading 
version 1 saved virtual machines.

Paolo