On 19 October 2018 at 17:26, Laurent Vivier <[email protected]> wrote: > Le 19/10/2018 à 18:17, Peter Maydell a écrit : >> Remove some dead code spotted by Coverity (CID 1009855, >> 1390854, 1390847). The underlying cause in all these cases >> is the same: QEMU's put_user operations can't result in >> errors, but the kernel's equivalent does. So when code >> was copied from the kernel signal-frame-setup/teardown >> code, checks on error flags that were needed in the kernel >> became dead code for us. >> >> Signed-off-by: Peter Maydell <[email protected]> >> --- >> linux-user/m68k/signal.c | 3 --- >> linux-user/sh4/signal.c | 4 ---- >> linux-user/sparc/signal.c | 2 -- >> 3 files changed, 9 deletions(-) >> > > Reviewed-by: Laurent Vivier <[email protected]>
Ping? Looks like you reviewed this but it hasn't made it into a pullreq. thanks -- PMM
