On Sun 11 Nov 2018 10:01:05 PM CET, Max Reitz wrote:
>> - assert(qemu_opt_find(opts, BDRV_OPT_CACHE_DIRECT));
>> if (qemu_opt_get_bool_del(opts, BDRV_OPT_CACHE_DIRECT, false)) {
>> *flags |= BDRV_O_NOCACHE;
>> }
>>
>> *flags &= ~BDRV_O_RDWR;
>
> Unrelated to this patch, but isn't BDRV_O_AUTO_RDONLY missing here?I forgot to mention, but I think you're right here. I'll include this fix in the next version of the series. Berto
