Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20181110134548.14741-1-marcandre.lur...@redhat.com
Subject: [Qemu-devel] [PATCH for-3.2 00/13] slirp: cleanups
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6e72a3d7d6 slirp: simplify fork_exec()
e4480abd5c glib-compat: add g_spawn_async_with_fds() fallback
05ec44d7a6 slirp: replace the poor-man string split with g_strsplit()
8b1f6fbfd4 slirp: improve subprocess socket creation
12e0630348 slirp: fix slirp_add_exec() leaks
402402c195 slirp: remove Monitor dependency, return a string for info
f16529aaa3 slirp: move internal function declarations
49749759e0 slirp: rename /extra/chardev
d4b52f3f73 slirp: remove unused EMU_RSH
738c429d7e slirp: use a dedicated field for chardev pointer
9cb6724b98 slirp: replace ex_pty with ex_chardev
ec0916fd51 slirp: remove do_pty from fork_exec()
588e3ea467 slirp: associate slirp_output callback with the Slirp context
=== OUTPUT BEGIN ===
Checking PATCH 1/13: slirp: associate slirp_output callback with the Slirp
context...
Checking PATCH 2/13: slirp: remove do_pty from fork_exec()...
Checking PATCH 3/13: slirp: replace ex_pty with ex_chardev...
ERROR: code indent should never use tabs
#23: FILE: slirp/misc.c:56:
+^I(*ex_ptr)->ex_chardev = do_pty == 3;$
ERROR: code indent should never use tabs
#36: FILE: slirp/misc.h:12:
+^Iint ex_chardev;$
total: 2 errors, 0 warnings, 52 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/13: slirp: use a dedicated field for chardev pointer...
ERROR: code indent should never use tabs
#78: FILE: slirp/misc.c:53:
+^I*ex_ptr = g_new0(struct ex_list, 1);$
ERROR: code indent should never use tabs
#83: FILE: slirp/misc.c:56:
+^Iif (chardev) {$
ERROR: code indent should never use tabs
#84: FILE: slirp/misc.c:57:
+^I^I(*ex_ptr)->ex_chardev = chardev;$
ERROR: code indent should never use tabs
#85: FILE: slirp/misc.c:58:
+^I} else {$
ERROR: code indent should never use tabs
#86: FILE: slirp/misc.c:59:
+^I^I(*ex_ptr)->ex_exec = g_strdup(cmdline);$
ERROR: code indent should never use tabs
#87: FILE: slirp/misc.c:60:
+^I}$
ERROR: code indent should never use tabs
#100: FILE: slirp/misc.h:12:
+^Ivoid *ex_chardev;$
total: 7 errors, 0 warnings, 100 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/13: slirp: remove unused EMU_RSH...
Checking PATCH 6/13: slirp: rename /extra/chardev...
ERROR: "foo * bar" should be "foo *bar"
#40: FILE: slirp/socket.h:70:
+ void * chardev;
total: 1 errors, 0 warnings, 28 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/13: slirp: move internal function declarations...
Checking PATCH 8/13: slirp: remove Monitor dependency, return a string for
info...
Checking PATCH 9/13: slirp: fix slirp_add_exec() leaks...
ERROR: code indent should never use tabs
#23: FILE: slirp/misc.h:15:
+^Ichar *ex_exec; /* Command line of what to exec */$
total: 1 errors, 0 warnings, 22 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/13: slirp: improve subprocess socket creation...
ERROR: code indent should never use tabs
#98: FILE: slirp/misc.c:137:
+^Iint opt, c, i, sp[2];$
ERROR: code indent should never use tabs
#125: FILE: slirp/misc.c:152:
+^I^Iclosesocket(sp[0]);$
ERROR: code indent should never use tabs
#126: FILE: slirp/misc.c:153:
+^I^Iclosesocket(sp[1]);$
ERROR: code indent should never use tabs
#151: FILE: slirp/misc.c:158:
+^I^Idup2(sp[1], 0);$
ERROR: code indent should never use tabs
#152: FILE: slirp/misc.c:159:
+^I^Idup2(sp[1], 1);$
ERROR: code indent should never use tabs
#153: FILE: slirp/misc.c:160:
+^I^Idup2(sp[1], 2);$
ERROR: code indent should never use tabs
#154: FILE: slirp/misc.c:161:
+^I^Ifor (c = getdtablesize() - 1; c >= 3; c--)$
ERROR: suspect code indent for conditional statements (16, 19)
#154: FILE: slirp/misc.c:161:
+ for (c = getdtablesize() - 1; c >= 3; c--)
+ close(c);
ERROR: braces {} are necessary for all arms of this statement
#154: FILE: slirp/misc.c:161:
+ for (c = getdtablesize() - 1; c >= 3; c--)
[...]
ERROR: code indent should never use tabs
#155: FILE: slirp/misc.c:162:
+^I^I close(c);$
total: 10 errors, 0 warnings, 167 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/13: slirp: replace the poor-man string split with
g_strsplit()...
ERROR: code indent should never use tabs
#27: FILE: slirp/misc.c:133:
+^Ichar **argv;$
ERROR: code indent should never use tabs
#28: FILE: slirp/misc.c:134:
+^Iint opt, c, sp[2];$
total: 2 errors, 0 warnings, 33 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/13: glib-compat: add g_spawn_async_with_fds() fallback...
Checking PATCH 13/13: slirp: simplify fork_exec()...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
