On 10/30/18 20:50, Paolo Bonzini wrote: > From: Marc-André Lureau <[email protected]> > > GuestPhysBlockList is currently used to produce dumps. Given the size > and the typical usage of NVDIMM for storage, they are not a good idea > to have in the dumps. We may want to have an extra dump option to > include them. For now, skip non-volatile regions. > > The TCG memory clear function is going to use the GuestPhysBlockList > as well, and will thus skip NVDIMM for similar reasons. > > Cc: [email protected] > Signed-off-by: Marc-André Lureau <[email protected]> > Message-Id: <[email protected]> > Signed-off-by: Paolo Bonzini <[email protected]> > --- > memory_mapping.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/memory_mapping.c b/memory_mapping.c > index 775466f..724dd0b 100644 > --- a/memory_mapping.c > +++ b/memory_mapping.c > @@ -206,7 +206,8 @@ static void guest_phys_blocks_region_add(MemoryListener > *listener, > > /* we only care about RAM */ > if (!memory_region_is_ram(section->mr) || > - memory_region_is_ram_device(section->mr)) { > + memory_region_is_ram_device(section->mr) || > + memory_region_is_nonvolatile(section->mr)) { > return; > } > >
This patch misses my R-b, and (in chronological order) DavidH's, from: http://mid.mail-archive.com/[email protected] http://mid.mail-archive.com/[email protected] Thanks Laszlo
