On 30 October 2018 at 20:57, Michael Roth <[email protected]> wrote: > Sorry for the breakage. Static is indeed useful for qemu-ga, but libudev > isn't a hard dependency for qemu-ga so we can get away with simply > disabling libudev for static builds. Would the following (squashed into > patch 04/24) be acceptable? This fixes static qemu-ga builds for me for > both Ubuntu 18.04 and FC27. I'll go ahead submit a v2 shortly since it > may be late for you: > > --- a/configure > +++ b/configure > @@ -5608,7 +5608,7 @@ fi > ########################################## > # Do we have libudev > if test "$libudev" != "no" ; then > - if $pkg_config libudev; then > + if $pkg_config libudev && test "$static" != "yes"; then > if test "$static" != "yes"; then
Now you've ruled out 'static' in the outer if, this inner if can never be false... > libudev="yes" > libudev_libs=$($pkg_config --libs libudev) thanks -- PMM
