On 30 October 2018 at 11:40, Philippe Mathieu-Daudé <[email protected]> wrote: > From: Guenter Roeck <[email protected]> > > QEMU already supports pl330. Instantiate it for smdkc210. > > Signed-off-by: Guenter Roeck <[email protected]> > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > Reviewed-by: Alistair Francis <[email protected]> > [PMD: Do not set default qdev properties] > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > hw/arm/exynos4_boards.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+)
> static void exynos4_boards_init_ram(Exynos4BoardState *s, > MemoryRegion *system_mem, > unsigned long ram_size) > @@ -171,6 +187,14 @@ static void smdkc210_init(MachineState *machine) > > lan9215_init(SMDK_LAN9118_BASE_ADDR, > qemu_irq_invert(s->soc->irq_table[exynos4210_get_irq(37, 1)])); > + > + pl330_init(SMDK_PL330_BASE0_ADDR, > + qemu_irq_invert(s->soc->irq_table[exynos4210_get_irq(35, 1)]), > 32); > + pl330_init(SMDK_PL330_BASE1_ADDR, > + qemu_irq_invert(s->soc->irq_table[exynos4210_get_irq(36, 1)]), > 32); > + pl330_init(SMDK_PL330_BASE2_ADDR, > + qemu_irq_invert(s->soc->irq_table[exynos4210_get_irq(34, 1)]), > 1); > + > arm_load_kernel(ARM_CPU(first_cpu), &exynos4_board_binfo); > } Are the PL330s really on the board and not part of the SoC? The layout of the dts files in the kernel suggests they're in the SoC, in which case they would belong in hw/arm/exynos4210.c. thanks -- PMM
