On 30/10/2018 06:46, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier <[email protected]> >> >> This is broken as the linux driver seems broken too... >> >> Co-developed-by: Mark Cave-Ayland <[email protected]> >> Signed-off-by: Mark Cave-Ayland <[email protected]> >> Signed-off-by: Laurent Vivier <[email protected]> >> --- >> hw/audio/Makefile.objs | 1 + >> hw/audio/asc.c | 446 >> +++++++++++++++++++++++++++++++++++++++++++++++++ >> include/hw/audio/asc.h | 48 ++++++ >> 3 files changed, 495 insertions(+) >> create mode 100644 hw/audio/asc.c >> create mode 100644 include/hw/audio/asc.h > > According to above comment, this device is broken. > Is it necessary for Q800 emulation? What happens if you remove it?
A quick test here shows that I can still boot without it, so it doesn't seem to be essential. Laurent, should we remove this from the next revision of the patchset? The general consensus seems to be that if a device isn't required (for now) then it shouldn't be included. ATB, Mark.
