On 10/24/18 12:37 PM, Richard Henderson wrote:
> - int i, ret, fdarray[3];
> + int i, err = 0, fdarray[3];
Bah. The bit about having compile-tested for arm32 was fake news -- "i" is now
unused. Ho hum.
> @@ -77,16 +69,15 @@ bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures
> *ahcf)
> */
> ahcf->dtb_compatible = "arm,arm-v7";
>
> - for (i = 0; i < ARRAY_SIZE(idregs); i++) {
> - ret = ioctl(fdarray[2], KVM_GET_ONE_REG, &idregs[i]);
> - if (ret) {
> - break;
> - }
> - }
> + err |= read_sys_reg32(fdarray[2], &midr, ARM_CP15_REG32(0, 0, 0, 0));
> + err |= read_sys_reg32(fdarray[2], &id_pfr0, ARM_CP15_REG32(0, 0, 1, 0));
> + err |= read_sys_reg32(fdarray[2], &mvfr1,
> + KVM_REG_ARM | KVM_REG_SIZE_U32 |
> + KVM_REG_ARM_VFP | KVM_REG_ARM_VFP_MVFR1);
r~