On 10/10/18 1:37 PM, Aaron Lindsay wrote:
> --- a/target/arm/machine.c
> +++ b/target/arm/machine.c
> @@ -584,7 +584,7 @@ static int cpu_pre_save(void *opaque)
> {
> ARMCPU *cpu = opaque;
>
> - pmccntr_op_start(&cpu->env);
> + pmu_op_start(&cpu->env);
Does it make sense to move this patch earlier so that these hooks are modified
once? No big deal if not.
> +static inline bool pmu_counter_enabled(CPUARMState *env, uint8_t counter)
Drop the inline. This function is pretty big; we should let the compiler
choose.
Otherwise,
Reviewed-by: Richard Henderson <[email protected]>
r~
