Re: [Qemu-devel] [PATCH 19/28] target/riscv: Replace gen_branch() with trans_branch()

[Richard Henderson]

On 10/12/18 10:30 AM, Bastian Koppelmann wrote:
> +static bool trans_branch(DisasContext *ctx, arg_branch *a, TCGCond cond)

I think you should still call it gen_branch.
Reserve the trans_ prefix for things called from the decoder.

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~