On 8 October 2018 at 17:16, Cornelia Huck <[email protected]> wrote: > On Mon, 8 Oct 2018 17:32:04 +0200 > David Hildenbrand <[email protected]> wrote: > >> linux-user should always enable AFP, otherwise our emulated binary >> might crash once it tries to make use of additional floating-point >> registers or instructions. >> >> Cc: Peter Maydell <[email protected]> >> Cc: Alex Bennée <[email protected]> >> Fixes: db0504154e ("s390x/tcg: check for AFP-register, BFP and DFP data >> exceptions") >> Reported-by: Alex Bennée <[email protected]> >> Signed-off-by: David Hildenbrand <[email protected]> >> --- >> target/s390x/cpu.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c >> index 8ed4823d6e..18ba7f85a5 100644 >> --- a/target/s390x/cpu.c >> +++ b/target/s390x/cpu.c >> @@ -145,6 +145,11 @@ static void s390_cpu_full_reset(CPUState *s) >> env->cregs[0] = CR0_RESET; >> env->cregs[14] = CR14_RESET; >> >> +#if defined(CONFIG_USER_ONLY) >> + /* user mode should always be allowed to use the full FPU */ >> + env->cregs[0] |= CR0_AFP; >> +#endif >> + >> /* architectured initial value for Breaking-Event-Address register */ >> env->gbea = 1; >> > > In case this is applied directly: > > Reviewed-by: Cornelia Huck <[email protected]> > Tested-by: Cornelia Huck <[email protected]>
Thanks; I've applied it to master, and also added 'make check-tcg' to my set of things I run as part of a merge, which should catch this kind of bug in future. -- PMM
