Hi Li, On 09/10/2018 04:39, Li Qiang wrote: > It makes sense to print the error message while reading > file failed.
OK > > Change since v1: > free error Changes are useful for reviewer, but not in the git history. You can have them automatically stripped if you place them below the next '---' separator. Hopefully the maintainer taking this patch can clean this up. > > Signed-off-by: Li Qiang <[email protected]> > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > --- Here goes comment not worth to stay forever in git history: Since v1: ... > vl.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/vl.c b/vl.c > index 4e25c78..69fc77c 100644 > --- a/vl.c > +++ b/vl.c > @@ -2207,8 +2207,10 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, > Error **errp) > size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */ > buf = g_memdup(str, size); > } else { > - if (!g_file_get_contents(file, &buf, &size, NULL)) { > - error_report("can't load %s", file); > + GError *error = NULL; > + if (!g_file_get_contents(file, &buf, &size, &error)) { > + error_report("can't load %s, %s", file, error->message); If you ever respin, you can help Markus [1] effort using: error_setg(errp, "can't load %s, %s", file, error->message); Else your patch will clash with [2]. > + g_error_free(error); > return -1; > } > } > Regards, Phil. [1] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01394.html [2] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01406.html
