On Mon, Oct 08, 2018 at 07:31:19PM +0200, Markus Armbruster wrote: > Calling error_report() in a function that takes an Error ** argument > is suspicious. parse_numa() does that, and then fails without setting > an error. Its caller main(), via qemu_opts_foreach(), is fine with > it, but clean it up anyway. > > While there, give parse_numa() internal linkage. > > Cc: Eduardo Habkost <ehabk...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> Queueing on machine-next. Thanks! -- Eduardo
