On Wed, Feb 23, 2011 at 11:54 AM, Kevin Wolf <[email protected]> wrote: > It's wrong to call BHs directly, even in tools. The only operations that > schedule BHs are called in a loop that (indirectly) contains a call to > qemu_bh_poll anyway, so we're not losing the scheduled BHs: Tools either use > synchronous functions, which are guaranteed to have completed (including any > BHs) when they return; or if they use asynchronous functions, they need to > call > qemu_aio_wait() or similar functions already today. > > Signed-off-by: Kevin Wolf <[email protected]> > --- > Makefile.objs | 4 ++-- > qemu-tool.c | 47 ++++------------------------------------------- > 2 files changed, 6 insertions(+), 45 deletions(-)
We discussed this on IRC and I think it makes sense. Review from others would be appreciated. Reviewed-by: Stefan Hajnoczi <[email protected]>
