Oops, sorry. Would something like that be OK:
On 9/26/18 1:55 PM, Alberto Garcia wrote:
> On Wed 26 Sep 2018 12:43:03 PM CEST, Kevin Wolf wrote:
>>> + /* Update cache sizes */
>>> + options = qdict_clone_shallow(bs->options);
>>> + ret = qcow2_update_options(bs, options, s->flags, errp);
+ qobject_unref(options);
>>> + if (ret < 0) {
>>> + goto fail;
>>> + }
>>Leonid. >> Isn't options leaked, both in success and error cases? > > I'm embarrassed not to have seen that :-! > > Berto >
