Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: [email protected] Subject: [Qemu-devel] [PATCH v9 00/84] Add nanoMIPS support to QEMU === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' a1a72634da qemu-doc: Add nanoMIPS-related items 6b0e4a5bed gdbstub: Add XML support for GDB for nanoMIPS f52a089394 gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub 5f142a7f45 linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh 659d8ae1d2 linux-user: Add nanoMIPS linux user mode configuration support bc2b17acba linux-user: Add support for nanoMIPS core files f85e52df38 linux-user: Add support for statx() syscall for all platforms a83b0978d7 linux-user: Amend support for sigaction() syscall for nanoMIPS 2d70411dd7 linux-user: Add cpu_loop.c for nanoMIPS db9b944cb1 linux-user: Add support for nanoMIPS signal trampoline f81b94f27d linux-user: Add signal.c for nanoMIPS 69b33591d8 linux-user: Add target_elf.h header for nanoMIPS dcefb34f92 linux-user: Add target_structs.h header for nanoMIPS aa2c053141 linux-user: Add target_cpu.h header for nanoMIPS 97cc893282 linux-user: Add target_syscall.h header for nanoMIPS 53ec0f262a linux-user: Add sockbits.h header for nanoMIPS bca5609efd linux-user: Add target_fcntl.h header for nanoMIPS d3ddf176f1 linux-user: Update syscall_defs.h header for nanoMIPS 1e743454c7 linux-user: Add termbits.h header for nanoMIPS 7c22c6c329 linux-user: Add target_signal.h header for nanoMIPS d01af10006 linux-user: Add syscall numbers for nanoMIPS b2174ff5a4 elf: Add nanoMIPS specific variations in ELF header fields 2e7015c623 target/mips: Add definition of nanoMIPS I7200 CPU 3f96d01420 mips_malta: Fix semihosting argument passing for nanoMIPS bare metal 0573ead99a mips_malta: Add setting up GT64120 BARs to the nanoMIPS bootloader e6555b01ef mips_malta: Add basic nanoMIPS boot code for Malta board c143508151 elf: On elf loading, treat both EM_MIPS and EM_NANOMIPS as legal for MIPS c3dca3b23f elf: Don't check FCR31_NAN2008 bit for nanoMIPS eefffbac2e elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too 47b7a54ee6 elf: Add EM_NANOMIPS value as a valid one for e_machine field 273d998114 target/mips: Fix ERET/ERETNC behavior related to ADEL exception caacbe0eb4 target/mips: Adjust set_pc() for nanoMIPS 7b0ee7a295 target/mips: Adjust set_hflags_for_handler() for nanoMIPS 6863647c24 target/mips: Adjust exception_resume_pc() for nanoMIPS 571dfe937a target/mips: Add updating BadInstr, BadInstrP, BadInstrX for nanoMIPS 2a18c544e3 target/mips: Add handling of ISA mode bit for nanoMIPS 9e3f869adc disas: Add support for microMIPS and nanoMIPS e8e218964c target/mips: Add emulation of DSP ASE for nanoMIPS - part 6 3e47dc67c3 target/mips: Add emulation of DSP ASE for nanoMIPS - part 5 1de728e9e3 target/mips: Add emulation of DSP ASE for nanoMIPS - part 4 820969ddbe target/mips: Add emulation of DSP ASE for nanoMIPS - part 3 f7dd4bb0ff target/mips: Add emulation of DSP ASE for nanoMIPS - part 2 e83aba8000 target/mips: Add emulation of DSP ASE for nanoMIPS - part 1 ad05be4532 target/mips: Implement MT ASE support for nanoMIPS 9cd68df113 target/mips: Fix pre-nanoMIPS MT ASE instructions availability control 111896a725 target/mips: Add emulation of nanoMIPS 32-bit branch instructions b7beb2231a target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair c9f518e478 target/mips: Add emulation of nanoMIPS 32-bit load and store instructions e9280f3f61 target/mips: Implement emulation of nanoMIPS EXTW instruction 1a2ba0c63f target/mips: Implement emulation of nanoMIPS ROTX instruction 03c8c9b0de target/mips: Add emulation of misc nanoMIPS instructions (p_lsx) a4b29366b0 target/mips: Add emulation of misc nanoMIPS instructions (pool32axf) 2d5e4a0900 target/mips: Add emulation of misc nanoMIPS instructions (pool32a0) 3047cb0427 target/mips: Add emulation of nanoMIPS FP instructions 325d0832ee target/mips: Add emulation of nanoMIPS 48-bit instructions 90e962edc4 target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV 8bb5f354f0 target/mips: Add emulation of some common nanoMIPS 32-bit instructions 92dd2d2010 target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions 8b250d1857 target/mips: Add emulation of nanoMIPS 16-bit logic instructions a59cb3b7ce target/mips: Add emulation of nanoMIPS 16-bit load and store instructions e52f2bed61 target/mips: Add emulation of nanoMIPS 16-bit misc instructions 147f444f9e target/mips: Add emulation of nanoMIPS 16-bit shift instructions 911ac40da5 target/mips: Add emulation of nanoMIPS 16-bit branch instructions 33bebcc220 target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions f27c375d46 target/mips: Add nanoMIPS decoding and extraction utilities 5f78b4fe03 target/mips: Add placeholder and invocation of decode_nanomips_opc() e808b9763d target/mips: Add nanoMIPS DSP ASE opcodes 2ec0c6f5cb target/mips: Add nanoMIPS base instruction set opcodes 92cf9adc27 target/mips: Add preprocessor constants for nanoMIPS 9b2a73f39d qemu-doc: Amend MIPS-related items e9fb9d27a8 linux-user: Add preprocessor availability control to some syscalls da5d92d0ad linux-user: Update MIPS syscall numbers up to kernel 4.18 headers cb9622e05d elf: Add ELF flags for MIPS machine variants 2b7defe4b2 elf: Remove duplicate preprocessor constant definition 7757c99e46 target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0 d0745caa77 target/mips: Don't update BadVAddr register in Debug Mode caff105e98 target/mips: Implement CP0 Config1.WR bit functionality 89dfd7911a target/mips: Add CP0 BadInstrX register b27cf9860e target/mips: Update some CP0 registers bit definitions e00d0228da target/mips: Fix two instances of shadow variables 36f4cc5acb target/mips: Mark switch fallthroughs with interpretable comments 16d2909df0 target/mips: Avoid case statements formulated by ranges - part 2 5a104b9359 target/mips: Avoid case statements formulated by ranges - part 1 649365aaee MAINTAINERS: Update target/mips maintainer's email addresses === OUTPUT BEGIN === Checking PATCH 1/84: MAINTAINERS: Update target/mips maintainer's email addresses... Checking PATCH 2/84: target/mips: Avoid case statements formulated by ranges - part 1... Checking PATCH 3/84: target/mips: Avoid case statements formulated by ranges - part 2... Checking PATCH 4/84: target/mips: Mark switch fallthroughs with interpretable comments... Checking PATCH 5/84: target/mips: Fix two instances of shadow variables... Checking PATCH 6/84: target/mips: Update some CP0 registers bit definitions... Checking PATCH 7/84: target/mips: Add CP0 BadInstrX register... Checking PATCH 8/84: target/mips: Implement CP0 Config1.WR bit functionality... Checking PATCH 9/84: target/mips: Don't update BadVAddr register in Debug Mode... Checking PATCH 10/84: target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0... Checking PATCH 11/84: elf: Remove duplicate preprocessor constant definition... Checking PATCH 12/84: elf: Add ELF flags for MIPS machine variants... Checking PATCH 13/84: linux-user: Update MIPS syscall numbers up to kernel 4.18 headers... Checking PATCH 14/84: linux-user: Add preprocessor availability control to some syscalls... Checking PATCH 15/84: qemu-doc: Amend MIPS-related items... Checking PATCH 16/84: target/mips: Add preprocessor constants for nanoMIPS... Checking PATCH 17/84: target/mips: Add nanoMIPS base instruction set opcodes... Checking PATCH 18/84: target/mips: Add nanoMIPS DSP ASE opcodes... Checking PATCH 19/84: target/mips: Add placeholder and invocation of decode_nanomips_opc()... Checking PATCH 20/84: target/mips: Add nanoMIPS decoding and extraction utilities... Checking PATCH 21/84: target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions... Checking PATCH 22/84: target/mips: Add emulation of nanoMIPS 16-bit branch instructions... Checking PATCH 23/84: target/mips: Add emulation of nanoMIPS 16-bit shift instructions... Checking PATCH 24/84: target/mips: Add emulation of nanoMIPS 16-bit misc instructions... Checking PATCH 25/84: target/mips: Add emulation of nanoMIPS 16-bit load and store instructions... Checking PATCH 26/84: target/mips: Add emulation of nanoMIPS 16-bit logic instructions... Checking PATCH 27/84: target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions... Checking PATCH 28/84: target/mips: Add emulation of some common nanoMIPS 32-bit instructions... Checking PATCH 29/84: target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV... Checking PATCH 30/84: target/mips: Add emulation of nanoMIPS 48-bit instructions... Checking PATCH 31/84: target/mips: Add emulation of nanoMIPS FP instructions... Checking PATCH 32/84: target/mips: Add emulation of misc nanoMIPS instructions (pool32a0)... Checking PATCH 33/84: target/mips: Add emulation of misc nanoMIPS instructions (pool32axf)... Checking PATCH 34/84: target/mips: Add emulation of misc nanoMIPS instructions (p_lsx)... Checking PATCH 35/84: target/mips: Implement emulation of nanoMIPS ROTX instruction... Checking PATCH 36/84: target/mips: Implement emulation of nanoMIPS EXTW instruction... Checking PATCH 37/84: target/mips: Add emulation of nanoMIPS 32-bit load and store instructions... Checking PATCH 38/84: target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair... Checking PATCH 39/84: target/mips: Add emulation of nanoMIPS 32-bit branch instructions... Checking PATCH 40/84: target/mips: Fix pre-nanoMIPS MT ASE instructions availability control... Checking PATCH 41/84: target/mips: Implement MT ASE support for nanoMIPS... Checking PATCH 42/84: target/mips: Add emulation of DSP ASE for nanoMIPS - part 1... Checking PATCH 43/84: target/mips: Add emulation of DSP ASE for nanoMIPS - part 2... Checking PATCH 44/84: target/mips: Add emulation of DSP ASE for nanoMIPS - part 3... Checking PATCH 45/84: target/mips: Add emulation of DSP ASE for nanoMIPS - part 4... Checking PATCH 46/84: target/mips: Add emulation of DSP ASE for nanoMIPS - part 5... Checking PATCH 47/84: target/mips: Add emulation of DSP ASE for nanoMIPS - part 6... Checking PATCH 48/84: disas: Add support for microMIPS and nanoMIPS... ERROR: externs should be avoided in .c files #330: FILE: disas/mips.c:6074: +int nanomips_dis(char *buf, unsigned address, unsigned short one, WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #414: new file mode 100644 ERROR: space required before that '*' (ctx:OxV) #860: FILE: disas/nanomips.cpp:442: + if ((cond == 0) || (this->*cond)(op_code)) { ^ ERROR: space required before that '*' (ctx:OxV) #888: FILE: disas/nanomips.cpp:470: + dis = (this->*dis_fn)(op_code); ^ ERROR: space prohibited between function name and open parenthesis '(' #17393: FILE: include/disas/bfd.h:390: +int print_insn_micromips (bfd_vma, disassemble_info*); total: 4 errors, 1 warnings, 17374 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 49/84: target/mips: Add handling of ISA mode bit for nanoMIPS... Checking PATCH 50/84: target/mips: Add updating BadInstr, BadInstrP, BadInstrX for nanoMIPS... Checking PATCH 51/84: target/mips: Adjust exception_resume_pc() for nanoMIPS... Checking PATCH 52/84: target/mips: Adjust set_hflags_for_handler() for nanoMIPS... Checking PATCH 53/84: target/mips: Adjust set_pc() for nanoMIPS... Checking PATCH 54/84: target/mips: Fix ERET/ERETNC behavior related to ADEL exception... Checking PATCH 55/84: elf: Add EM_NANOMIPS value as a valid one for e_machine field... Checking PATCH 56/84: elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too... Checking PATCH 57/84: elf: Don't check FCR31_NAN2008 bit for nanoMIPS... Checking PATCH 58/84: elf: On elf loading, treat both EM_MIPS and EM_NANOMIPS as legal for MIPS... Checking PATCH 59/84: mips_malta: Add basic nanoMIPS boot code for Malta board... Checking PATCH 60/84: mips_malta: Add setting up GT64120 BARs to the nanoMIPS bootloader... Checking PATCH 61/84: mips_malta: Fix semihosting argument passing for nanoMIPS bare metal... Checking PATCH 62/84: target/mips: Add definition of nanoMIPS I7200 CPU... Checking PATCH 63/84: elf: Add nanoMIPS specific variations in ELF header fields... Checking PATCH 64/84: linux-user: Add syscall numbers for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 275 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 65/84: linux-user: Add target_signal.h header for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 22 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 66/84: linux-user: Add termbits.h header for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 11 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 67/84: linux-user: Update syscall_defs.h header for nanoMIPS... Checking PATCH 68/84: linux-user: Add target_fcntl.h header for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 38 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 69/84: linux-user: Add sockbits.h header for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 1 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 70/84: linux-user: Add target_syscall.h header for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 30 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 71/84: linux-user: Add target_cpu.h header for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 21 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 72/84: linux-user: Add target_structs.h header for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 1 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 73/84: linux-user: Add target_elf.h header for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 14 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 74/84: linux-user: Add signal.c for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #113: new file mode 100644 total: 0 errors, 1 warnings, 84 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 75/84: linux-user: Add support for nanoMIPS signal trampoline... Checking PATCH 76/84: linux-user: Add cpu_loop.c for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 33 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 77/84: linux-user: Amend support for sigaction() syscall for nanoMIPS... Checking PATCH 78/84: linux-user: Add support for statx() syscall for all platforms... WARNING: architecture specific defines should be avoided #45: FILE: linux-user/syscall.c:10040: +#if defined(__NR_statx) total: 0 errors, 1 warnings, 175 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 79/84: linux-user: Add support for nanoMIPS core files... Checking PATCH 80/84: linux-user: Add nanoMIPS linux user mode configuration support... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #60: new file mode 100644 total: 0 errors, 1 warnings, 38 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 81/84: linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh... WARNING: line over 80 characters #30: FILE: scripts/qemu-binfmt-conf.sh:79: +nanomips_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xf9\x00' ERROR: line over 90 characters #31: FILE: scripts/qemu-binfmt-conf.sh:80: +nanomips_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff' WARNING: line over 80 characters #34: FILE: scripts/qemu-binfmt-conf.sh:83: +nanomipseb_magic='\x7fELF\x01\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xf9' ERROR: line over 90 characters #35: FILE: scripts/qemu-binfmt-conf.sh:84: +nanomipseb_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff' total: 2 errors, 2 warnings, 34 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 82/84: gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub... Checking PATCH 83/84: gdbstub: Add XML support for GDB for nanoMIPS... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 total: 0 errors, 1 warnings, 157 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 84/84: qemu-doc: Add nanoMIPS-related items... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
