On Wed, Aug 15, 2018 at 03:48:57PM +0200, Thomas Huth wrote: > On 08/15/2018 03:37 PM, Peter Xu wrote: > > The "0.15" prefix seems useless. Remove them. > > > > Signed-off-by: Peter Xu <[email protected]> > > --- > > tests/test-qmp-cmds.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c > > index ba41a6161e..989819b26d 100644 > > --- a/tests/test-qmp-cmds.c > > +++ b/tests/test-qmp-cmds.c > > @@ -286,11 +286,11 @@ int main(int argc, char **argv) > > { > > g_test_init(&argc, &argv, NULL); > > > > - g_test_add_func("/0.15/dispatch_cmd", test_dispatch_cmd); > > - g_test_add_func("/0.15/dispatch_cmd_failure", > > test_dispatch_cmd_failure); > > - g_test_add_func("/0.15/dispatch_cmd_io", test_dispatch_cmd_io); > > - g_test_add_func("/0.15/dealloc_types", test_dealloc_types); > > - g_test_add_func("/0.15/dealloc_partial", test_dealloc_partial); > > + g_test_add_func("/dispatch_cmd", test_dispatch_cmd); > > + g_test_add_func("/dispatch_cmd_failure", test_dispatch_cmd_failure); > > + g_test_add_func("/dispatch_cmd_io", test_dispatch_cmd_io); > > + g_test_add_func("/dealloc_types", test_dealloc_types); > > + g_test_add_func("/dealloc_partial", test_dealloc_partial); > > Most other tests use a common prefix, so maybe rather replace the "0.15" > with "qmp-cmd" here? E.g.: > > g_test_add_func("/qmp-cmd/dispatch_cmd", test_dispatch_cmd); > > ?
I'll drop this patch due to a dup in master. That one has "/qmp" prefix. Thanks Thomas. -- Peter Xu
