On 15 August 2018 at 11:54, Edgar E. Iglesias <[email protected]> wrote:
> On Tue, Aug 14, 2018 at 01:42:54PM +0100, Peter Maydell wrote:
>> Implement the necessary support code for taking exceptions
>> to Hyp mode in AArch32.
>
> Hi Peter,
>
> A general comment that I think this would be a little easier
> to look at if it was split into two patches, one non-functional
> change to break-out take_aarch32_exception() and then another
> patch to add the new logic...
Yeah, you're right. I'll split it.
>> + mask = 0;
>> + if (!(env->cp15.scr_el3 & SCR_EA)) {
>> + mask |= CPSR_A;
>> + }
>> + if (!(env->cp15.scr_el3 & SCR_IRQ)) {
>> + mask |= CPSR_I;
>> + }
>> + if (!(env->cp15.scr_el3 & SCR_IRQ)) {a
> ^^^^^^^
> I think this should test for SCR_FIQ.
Yep, cut-n-paste error.
thanks
-- PMM
