Ah got it, thanks for the replies / info! We're using a modified QEMU 2.12, and I don't see the migratable-only loops and field, so it either got missed in the rebase or was added after 2.12.
Frank On Mon, Aug 13, 2018 at 9:45 AM Dr. David Alan Gilbert <[email protected]> wrote: > * Paolo Bonzini ([email protected]) wrote: > > On 13/08/2018 18:16, Frank Yang wrote: > > > Hi Paolo, > > > > > > I see that migration/ram.c saves RAMBlocks associated with memory > > > regions initialized with nomigrate. Is this intended? > > > > Probably the name and size of the RAMBlocks must match but the contents > > need not (but honestly I haven't looked at the code to find the answer). > > CCing the qemu mailing list (always a good idea) and a couple people > > that might know. > > All the migration code should now be using RAMBLOCK_FOREACH_MIGRATABLE and > qemu_ram_is_migratable whenever it's iterating the ramblock list, > so that *shouldn't* happen these days. > Of course we could have messed it up somewhere; what are you seeing? > > Dave > > Paolo > -- > Dr. David Alan Gilbert / [email protected] / Manchester, UK >
