On Sun, Feb 13, 2011 at 08:29:05PM +0200, Blue Swirl wrote:
> On Sun, Feb 13, 2011 at 5:08 PM, Anthony Liguori <[email protected]>
> wrote:
> > On 02/13/2011 05:12 AM, David Gibson wrote:
[snip]
> > The arguments will have to be extracted from the CPU state but I don't think
> > we'll really ever have common hypercall implementations anyway so that's not
> > a huge problem.
>
> Nice idea. Then the part handling CPUState probably should belong to
> target-ppc/ rather than hw/.
Doesn't work. Different hypervisors may have arguments - even the
hcall number itself - arranged differently in the registers. My
earlier drafts had this in target-ppc/; I moved it to hw/ for a
reason.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson